Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for react 17 #175

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Allow for react 17 #175

merged 1 commit into from
Dec 11, 2020

Conversation

krainboltgreene
Copy link
Contributor

You may also want to add a react-dom peer.

@krainboltgreene
Allow for react 17
30f58b5 
You may also want to add a react-dom peer.
@krainboltgreene krainboltgreene mentioned this pull request Nov 26, 2020
Merged
@stof stof mentioned this pull request Dec 2, 2020
Open
@JedWatson
Copy link
Owner

Thanks for this @krainboltgreene, will release today!

@JedWatson JedWatson merged commit 6bc3cb7 into JedWatson:master Dec 11, 2020
@JedWatson
Copy link
Owner

You may also want to add a react-dom peer.

Is there a specific reason you suggest this? we're not importing it in the component, so consumers wouldn't need to depend on it for the component's sake

@krainboltgreene krainboltgreene deleted the patch-1 branch December 11, 2020 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krainboltgreene @JedWatson